On Fri, 23 Feb 2024 at 02:57, Jeff Davis <pg...@j-davis.com> wrote: > Sorry, I was unclear. I was asking a question about the reason the > ObjectClass and the object_classes[] array exist in the current code, > it wasn't a direct question about your patch.
I did a bit of git spelunking and the reason seems to be that back in 2002 when this was introduced not all relation ids were compile time constants and thus an array was initialized once at bootup. I totally agree with you that these days there's no reason for the array. So I now added a second patch that removes this array, instead of updating it to use the designated initializer syntax.
v2-0001-Remove-unnecessary-object_classes-array.patch
Description: Binary data
v2-0002-Use-designated-initializer-syntax-to-improve-read.patch
Description: Binary data