On Tue, Feb 20, 2024 at 6:19 PM Masahiko Sawada <sawada.m...@gmail.com> wrote: > > On Tue, Feb 20, 2024 at 12:33 PM shveta malik <shveta.ma...@gmail.com> wrote: > Thank you for the explanation. It makes sense to me to move the check. > > > 2. If the wal_level is not logical, the server will need to restart > anyway to change the wal_level and have the slotsync worker work. Does > it make sense to have the postmaster exit if the wal_level is not > logical and sync_replication_slots is enabled? For instance, we have > similar checks in PostmsaterMain(): > > if (summarize_wal && wal_level == WAL_LEVEL_MINIMAL) > ereport(ERROR, > (errmsg("WAL cannot be summarized when wal_level is > \"minimal\"")));
Thanks for the feedback. I have addressed it in v93. thanks SHveta