On Mon, 12 Feb 2024 at 14:33, vignesh C <vignes...@gmail.com> wrote: > > On Fri, 9 Feb 2024 at 12:30, Peter Smith <smithpb2...@gmail.com> wrote: > > > > Here are some review comments for patch v7-0001. > > > > ====== > > doc/src/sgml/glossary.sgml > > > > 1. > > + <glossentry id="glossary-logical-replication-cluster"> > > + <glossterm>Logical replication cluster</glossterm> > > + <glossdef> > > + <para> > > + A set of publisher and subscriber instance with publisher instance > > + replicating changes to the subscriber instance. > > + </para> > > + </glossdef> > > + </glossentry> > > > > 1a. > > /instance with/instances with/ > > Modified > > > ~~~ > > > > 1b. > > The description then made me want to look up the glossary definition > > of a "publisher instance" and "subscriber instance", but then I was > > quite surprised that even "Publisher" and "Subscriber" terms are not > > described in the glossary. Should this patch add those, or should we > > start another thread for adding them? > > I felt it is better to start a new thread for this
A new patch has been posted at [1] to address this. [1] - https://www.postgresql.org/message-id/CANhcyEXa%3D%2BshzbdS2iW9%3DY%3D_Eh7aRWZbQKJjDHVYiCmuiE1Okw%40mail.gmail.com Regards, Vignesh
