Hi,
On Wed, Jan 31, 2024 at 01:47:16PM +1100, Peter Smith wrote:
> Hi, thanks for the patch. Here are some review comments for v1
Thanks for the review!
>
> ======
>
> (below is not showing the links and other sgml rendering -- all those LGTM)
>
> BEFORE
> When altering the slot_name, the failover and two_phase properties
> values of the named slot may differ from their counterparts failover
> and two_phase parameters specified in the subscription. When creating
> the slot, ensure the slot failover and two_phase properties match
> their counterparts parameters values of the subscription.
>
> SUGGESTION
> When altering the slot_name, the failover and two_phase property
> values of the named slot may differ from the counterpart failover and
> two_phase parameters specified by the subscription. When creating the
> slot, ensure the slot properties failover and two_phase match their
> counterpart parameters of the subscription.
>
> ~
>
> BEFORE
> Otherwise, the slot on the publisher may behave differently from what
> subscription's failover and two_phase options say: for example, the
> slot on the publisher could ...
>
> SUGGESTION:
> Otherwise, the slot on the publisher may behave differently from what
> these subscription options say: for example, the slot on the publisher
> could ...
>
As a non native English speaker somehow I have to rely on you for those
suggestions ;-)
They make sense to me so applied both in v2 attached.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
>From 29ef47f6a201a81557ce1b4b37b414118a623634 Mon Sep 17 00:00:00 2001
From: Bertrand Drouvot <bertranddrouvot...@gmail.com>
Date: Tue, 30 Jan 2024 14:48:16 +0000
Subject: [PATCH v2] Documentation: warn about two_phase when altering a
subscription's slot name.
776621a5e4 added a warning about the newly failover option. Doing the same
for the already existing two_phase one.
---
doc/src/sgml/ref/alter_subscription.sgml | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
100.0% doc/src/sgml/ref/
diff --git a/doc/src/sgml/ref/alter_subscription.sgml b/doc/src/sgml/ref/alter_subscription.sgml
index e9e6d9d74a..11f69f330d 100644
--- a/doc/src/sgml/ref/alter_subscription.sgml
+++ b/doc/src/sgml/ref/alter_subscription.sgml
@@ -235,15 +235,15 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
<para>
When altering the
<link linkend="sql-createsubscription-params-with-slot-name"><literal>slot_name</literal></link>,
- the <literal>failover</literal> property value of the named slot may differ from the
+ the <literal>failover</literal> and <literal>two_phase</literal> property
+ values of the named slot may differ from the counterpart
<link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
- parameter specified in the subscription. When creating the slot,
- ensure the slot <literal>failover</literal> property matches the
- <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
- parameter value of the subscription. Otherwise, the slot on the
- publisher may behave differently from what subscription's
- <link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
- option says. The slot on the publisher could either be
+ and <link linkend="sql-createsubscription-params-with-two-phase"><literal>two_phase</literal></link>
+ parameters specified by the subscription. When creating the slot, ensure
+ the slot properties <literal>failover</literal> and <literal>two_phase</literal>
+ match their counterpart parameters of the subscription.
+ Otherwise, the slot on the publisher may behave differently from what these
+ subscription options say: for example, the slot on the publisher could either be
synced to the standbys even when the subscription's
<link linkend="sql-createsubscription-params-with-failover"><literal>failover</literal></link>
option is disabled or could be disabled for sync
--
2.34.1
