On Tue, Jan 30, 2024 at 11:23:57AM +1300, David Rowley wrote: > On Tue, 30 Jan 2024 at 08:32, Nathan Bossart <nathandboss...@gmail.com> wrote: >> I'm currently +0.1 for this change. I don't see any huge problem with >> trimming a few instructions, but I'm dubious there's any measurable impact. >> However, a cycle saved is a cycle earned... > > FWIW, In [1] and subsequent replies, there are several examples of > benchmarks where various bitmapset functions are sitting high in the > profiles. So I wouldn't be too surprised if such a small change to the > WORDNUM and BITNUM macros made a noticeable difference.
Good to know, thanks. If there is indeed demonstrable improvement, I'd readily adjust my +0.1 to +1. -- Nathan Bossart Amazon Web Services: https://aws.amazon.com
