On Mon, Jan 29, 2024 at 9:21 AM Peter Smith <smithpb2...@gmail.com> wrote: > > Here are some review comments for v70-0001. > > ====== > doc/src/sgml/protocol.sgml > > 1. > Related to this, please also review my other patch to the same docs > page protocol.sgml [1]. >
We can check that separately. > ====== > src/backend/replication/logical/tablesync.c > > 2. > walrcv_create_slot(LogRepWorkerWalRcvConn, > slotname, false /* permanent */ , false /* two_phase */ , > + false, > CRS_USE_SNAPSHOT, origin_startpos); > > I know it was previously mentioned in this thread that inline > parameter comments are unnecessary, but here they are already in the > existing code so shouldn't we do the same? > I think it is better to remove the even existing ones as those many times make code difficult to read. -- With Regards, Amit Kapila.
