On 08.01.24 22:08, Nathan Bossart wrote:
I think these are reasonable concerns, but with this patch, we now have the
following functions:
pg_get_identity_sequence(table regclass, column name) -> regclass
pg_get_serial_sequence(table text, column text) -> text
If we only look at the names, it sure sounds like the first one only works
for identity columns, and the second only works for serial columns. But
both work for identity_and_ serial. The real differences between the two
are the parameter and return types. Granted, this is described in the
documentation updates, but IMHO this is a kind-of bizarre state to end up
in.
Yeah, that's really weird.
Would it work to change the signature of pg_get_serial_sequence to
pg_get_serial_sequence(table anyelement, column text) -> anyelement
and then check inside the function code whether text or regclass was passed?
