On Wed, 20 Dec 2023 at 21:13, Peter Eisentraut <pe...@eisentraut.org> wrote:
>
> On 20.12.23 12:40, Andres Freund wrote:
> > Hm, or perhaps we should just get rid of sed use altogether. The sepgsql
> > case
> > is trivially translateable to perl, and postprocess_dtrace.sed isn't
> > much harder.
>
> Maybe yeah, but also it seems fine as is and we can easily fix the
> present issue ...
>
> > OTOH, I actually don't think it's valid to not have sed when you have
> > dtrace. Erroring out in a weird way in such an artificially constructed test
> > doesn't really seem like a problem.
>
> Agreed. So let's just make it not-required, and that should work.
>
> Updated patch set attached.
Thanks for the patches.
I noticed one issue about the flex 2.5.35 version mentioned.
I noticed some warning with meson build in windows with flex 2.5.35
for several files:
python = find_program(get_option('PYTHON'), required: true, native: true)
flex = find_program(get_option('FLEX'), native: true, version: '>= 2.5.35')
bison = find_program(get_option('BISON'), native: true, version: '>= 2.3')
-sed = find_program(get_option('SED'), 'sed', native: true)
+sed = find_program(get_option('SED'), 'sed', native: true, required: false)
prove = find_program(get_option('PROVE'), native: true, required: false)
tar = find_program(get_option('TAR'), native: true)
Compiling C object
src/test/isolation/isolationtester.exe.p/meson-generated_.._specscanner.c.obj
src/test/isolation/specscanner.c(2): warning C4129: 'W': unrecognized
character escape sequence
src/test/isolation/specscanner.c(2): warning C4129: 'P': unrecognized
character escape sequence
src/test/isolation/specscanner.c(2): warning C4129: 'p': unrecognized
character escape sequence
src/test/isolation/specscanner.c(2): warning C4129: 's': unrecognized
character escape sequence
src/test/isolation/specscanner.c(2): warning C4129: 'i': unrecognized
character escape sequence
I noticed this is because the lex file getting added without escape
characters in the C file:
#line 2 "D:\postgres\pg_meson\src\backend\utils\adt\jsonpath_scan.l"
There were no warnings when I used flex 2.6.4.
Did anyone else get these warnings with the flex 2.5.35 version?
Regards,
Vignesh
