> This change (Required in between two sentences) looks slightly odd to
> me. Can we instead extend the second line to something like: "This
> parameter is required, and the individual publication names are ...".
> Similarly we can adjust the proto_vesion explanation.

I don't think it's an improvement to join 2 independent sentences with
a comma.  I expanded these by mentioning what is required.

> This sounds like we are supporting more than one logical decoding
> plugin. Can we slightly rephrase it to something like:
> "PostgreSQL</productname> supports extensible logical decoding plugin
> <literal>pgoutput</literal> which is used for the built-in logical
> replication as well."

I understand the confusion.  I reworded it and dropped "extensible".

The new versions are attached.

Attachment: v03-0002-doc-Clarify-pgoutput-options.patch
Description: Binary data

Attachment: v03-0001-pgoutput-Test-if-proto_version-is-given.patch
Description: Binary data

Reply via email to