Hi, I had a look at the latest v02 patches. On Sat, Dec 16, 2023 at 12:36 AM Emre Hasegeli <e...@hasegeli.com> wrote: > > > OK, to deal with that can't you just include "origin" in the first > > group which has no special protocol requirements? > > I think it'd be confusing because the option is not available before > version 16. I think it should really check for the version number and > complain if it's less than 4.
Hm. I don't think a proto_version check is required for "origin". IIUC, the protocol version number indicates the message byte format. It's needed so that those messages bytes can be read/written in the same/compatible way. OTOH I thought the "origin" option has nothing really to do with actual message formats on the wire; I think it works just by filtering up-front to decide either to send the changes or not send the changes. For example, so long as PostgreSQL >= v16, I expect you could probably use "origin" with any proto_version you wanted. > > > SUGGESTION > > -proto_version > > -publication_names > > -binary > > -messages > > -origin > > > > Requires minimum protocol version 2: > > -streaming (boolean) > > > > Requires minimum protocol version 3: > > -two_phase > > > > Requires minimum protocol version 4: > > -streaming (parallel) > > I am still not sure if this is any better. I don't like that > "streaming" appears twice, and I wouldn't know how to format this > nicely. > I won't keep pushing to rearrange the docs. I think all the content is OK anyway, so let's see if other people have any opinions on how the new information is best presented. ====== Kind Regards, Peter Smith. Fujitsu Australia
