On Tue, Dec 12, 2023 at 02:29:03PM +0300, Nazir Bilal Yavuz wrote: > On Tue, 5 Dec 2023 at 09:16, Michael Paquier <mich...@paquier.xyz> wrote: >> This interface from pgstat_prepare_io_time() is not really good, >> because we could finish by setting io_start in the existing code paths >> calling this routine even if track_io_timing is false when >> track_wal_io_timing is true. Why not changing this interface a bit >> and pass down a GUC (track_io_timing or track_wal_io_timing) as an >> argument of the function depending on what we expect to trigger the >> timings? > > Done in 0001.
One thing that 0001 missed is an update of the header where the function is declared. I've edited a few things, and applied it to start on this stuff. The rest will have to wait a bit more.. -- Michael
signature.asc
Description: PGP signature
