On 2023-Nov-30, Ashutosh Bapat wrote: > Hi Alvaro, > Thanks for the review and the edits. Sorry for replying late. > > On Tue, Nov 21, 2023 at 11:56 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> > wrote: > > > > I gave this a quick look. I think the usefulness aspect is already > > established in general terms; the bit I'm not so sure about is whether > > we want it enabled by default. For many cases it'd just be noise. > > Perhaps we want it hidden behind something like "EXPLAIN (MEMORY)" or > > such, particularly since things like "allocated" (which, per David, > > seems to be the really useful metric) seems too much a PG-developer > > value rather than an end-user value. > > It is not default but hidden behind "SUMMARY".Do you still think it > requires another sub-flag MEMORY?
Well, SUMMARY is enabled by default with ANALYZE, and I'd rather not have planner memory consumption displayed by default with all EXPLAIN ANALYZEs. So yeah, I still think this deserves its own option. But let's hear others' opinions on this point. I'm only one vote here. -- Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ "All rings of power are equal, But some rings of power are more equal than others." (George Orwell's The Lord of the Rings)
