On Sat, 25 Nov 2023 at 17:50, Amit Kapila <amit.kapil...@gmail.com> wrote: > > 2. > + * b) SUBREL_STATE_SYNCDONE: A relation upgraded while in this state > + * would retain the replication origin in certain cases. > > I think this is vague. Can we briefly describe cases where the origins > would be retained?
Modified > 3. I think the cases where the publisher is also upgraded restoring > the origin's LSN is of no use. Currently, I can't see a problem with > restoring stale originLSN in such cases as we won't be able to > distinguish during the upgrade but I think we should document it in > the comments somewhere in the patch. Added comments These are handled in the v20 version patch attached at: https://www.postgresql.org/message-id/CALDaNm0ST1iSrJLD_CV6hQs%3Dw4GZRCRdftQvQA3cO8Hq3QUvYw%40mail.gmail.com Regards, Vignesh