On 2023-11-27 Mo 05:42, Alvaro Herrera wrote:
On 2023-Nov-27, Amit Langote wrote:
For example, the jump between 13 and 14 looks worse.
(I do wonder what happened there.)
The following commit sounds like it might be related?
Yes, but not only that one. I did some more trolling in the commit log
for the 14 timeframe further and found that the following commits are
the ones with highest additions to YYLAST during that cycle:
yylast │ yylast_addition │ commit │
subject
────────┼─────────────────┼────────────┼────────────────────────────────────────────────────────────────────────────────
106051 │ 1883 │ 92bf7e2d02 │ Provide the OR REPLACE option for
CREATE TRIGGER.
105325 │ 1869 │ 06a7c3154f │ Allow most keywords to be used as
column labels without requiring AS.
104395 │ 1816 │ 45b9805706 │ Allow CURRENT_ROLE where CURRENT_USER
is accepted
107537 │ 1139 │ a4d75c86bf │ Extended statistics on expressions
105410 │ 1067 │ b5913f6120 │ Refactor CLUSTER and REINDEX grammar
to use DefElem for option lists
106007 │ 965 │ 3696a600e2 │ SEARCH and CYCLE clauses
106864 │ 733 │ be45be9c33 │ Implement GROUP BY DISTINCT
105886 │ 609 │ 844fe9f159 │ Add the ability for the core grammar
to have more than one parse target.
108400 │ 571 │ ec48314708 │ Revert per-index collation version
tracking feature.
108939 │ 539 │ e6241d8e03 │ Rethink definition of
pg_attribute.attcompression.
but we also have these:
105521 │ -530 │ 926fa801ac │ Remove undocumented IS [NOT] OF
syntax.
104202 │ -640 │ c4325cefba │ Fold AlterForeignTableStmt into
AlterTableStmt
104168 │ -718 │ 40c24bfef9 │ Improve our ability to regurgitate
SQL-syntax function calls.
108111 │ -828 │ e56bce5d43 │ Reconsider the handling of procedure
OUT parameters.
106398 │ -834 │ 71f4c8c6f7 │ ALTER TABLE ... DETACH PARTITION ...
CONCURRENTLY
104402 │ -923 │ 2453ea1422 │ Support for OUT parameters in
procedures
103456 │ -939 │ 1ed6b89563 │ Remove support for postfix
(right-unary) operators.
104343 │ -1178 │ 873ea9ee69 │ Refactor parsing rules for option
lists of EXPLAIN, VACUUM and ANALYZE
102784 │ -1417 │ 8f5b596744 │ Refactor AlterExtensionContentsStmt
grammar
(59 filas)
Interesting. But inferring a speed effect from such changes is
difficult. I don't have a good idea about measuring parser speed, but a
tool to do that would be useful. Amit has made a start on such
measurements, but it's only a start. I'd prefer to have evidence rather
than speculation.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
