Hi, On 2023-11-15 16:21:45 -0500, Melanie Plageman wrote: > On Tue, Nov 14, 2023 at 7:15 PM Andres Freund <and...@anarazel.de> wrote: > > On 2023-11-14 07:46:10 -0500, Melanie Plageman wrote: > > > > FreeSpaceMapVacuumRange()'s comment says: > > > > * As above, but assume that only heap pages between start and end-1 > > > > inclusive > > > > * have new free-space information, so update only the upper-level slots > > > > * covering that block range. end == InvalidBlockNumber is equivalent > > > > to > > > > * "all the rest of the relation". > > > > > > > > So FreeSpaceMapVacuumRange(..., blkno) will not actually process the > > > > "effects" > > > > of the RecordPageWithFreeSpace() above it - which seems confusing. > > > > > > Ah, so shall I pass blkno + 1 as end? > > > > I think there's no actual overflow danger, because MaxBlockNumber + 1 is > > InvalidBlockNumber, which scans the rest of the relation (i.e. exactly the > > intended block). Perhaps worth noting? > > Attached
And pushed! Thanks for the report and fix! Greetings, Andres Freund
