On Fri, Nov 17, 2023 at 5:54 AM Nathan Bossart <nathandboss...@gmail.com> wrote: > > It looks like is_valid_ascii() was originally added to pg_wchar.h so that > it could easily be used elsewhere [0] [1], but that doesn't seem to have > happened yet. > > Would moving this definition to a separate header file be a viable option?
Seems fine to me. (I believe the original motivation for making it an inline function was for in pg_mbstrlen_with_len(), but trying that hasn't been a priority.)
