On Tue, Nov 14, 2023 at 9:50 PM Alvaro Herrera <alvhe...@alvh.no-ip.org> wrote: > > On 2023-Nov-13, Nathan Bossart wrote: > > > Shall we retire this backwards compatibility macro at this point? A search > > of https://codesearch.debian.net/ does reveal a few external uses, so we > > could alternatively leave it around and just update Postgres to stop using > > it, but I don't think it would be too burdensome for extension authors to > > fix if we removed it completely. > > Let's leave the macro around and just remove its uses in PGDG-owned > code. Having the macro around hurts nothing, and we can remove it in 15 > years or so.
FWIW, there are other backward compatibility macros out there like tuplestore_donestoring which was introduced by commit dd04e95 21 years ago and SPI_push() and its friends which were made no-ops macros by commit 1833f1a 7 years ago. Debian code search shows very minimal usages of the above macros. Can we do away with tuplestore_donestoring? -- Bharath Rupireddy PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com
