On Mon, Nov 13, 2023 at 5:01 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Fri, Nov 10, 2023 at 7:26 PM vignesh C <vignes...@gmail.com> wrote: > > > > Thanks for the comments, the attached v13 version patch has the > > changes for the same. > > > > + > + ReplicationOriginNameForLogicalRep(subid, InvalidOid, originname, > sizeof(originname)); > + originid = replorigin_by_name(originname, false); > + replorigin_advance(originid, sublsn, InvalidXLogRecPtr, > + false /* backward */ , > + false /* WAL log */ ); > > This seems to update the origin state only in memory. Is it sufficient > to use this here? >
I think it is probably getting ensured by clean shutdown (shutdown_checkpoint) which happens on the new cluster after calling this function. We can probably try to add a comment for it. BTW, we also need to ensure that max_replication_slots is configured to a value higher than origins we are planning to create on the new cluster. -- With Regards, Amit Kapila.
