On Tue, Nov 07, 2023 at 10:00:39PM +0100, Peter Eisentraut wrote: > Speaking of which, would it make sense to put this tool (whatever the name) > into the pg_basebackup directory? It's sort of related, and it also shares > some code.
I've read the patch, and the additions to streamutil.h and streamutil.c make it kind of natural to have it sit in pg_basebackup/. There's pg_recvlogical already there. I am wondering about two things, though: - Should the subdirectory pg_basebackup be renamed into something more generic at this point? All these things are frontend tools that deal in some way with the replication protocol to do their work. Say a replication_tools? - And if it would be better to refactor some of the code generic to all these streaming tools to fe_utils. What makes streamutil.h a bit less pluggable are all its extern variables to control the connection, but perhaps that can be an advantage, as well, in some cases. -- Michael
signature.asc
Description: PGP signature
