Hi again,
> PFA the corrected patchset v59.
On second thought, I believe this Assert is incorrect:
```
+ else
+ {
+ Assert(segno >= 0 && segno <= 0xFFFF);
+ return snprintf(path, MAXPGPATH, "%s/%04X", (ctl)->Dir,
+ (unsigned int) segno);
+ }
```
See SlruCorrectSegmentFilenameLength():
```
if (ctl->long_segment_names)
return (len == 15); /* see SlruFileName() */
else
/*
* Commit 638cf09e76d allowed 5-character lengths. Later commit
* 73c986adde5 allowed 6-character length.
*
* XXX should we still consider such names to be valid?
*/
return (len == 4 || len == 5 || len == 6);
```
Should we just drop it or check that segno is <= 0xFFFFFF?
--
Best regards,
Aleksander Alekseev
