Hi! Thanks for your review. I've actually missed the logic to retain some WALs required for replication slots or wal_keep_size setting. I've attached the updated version of the patch with an additional call to KeepLogSeg(). Now it passed all the tests, at least in my fork (https://cirrus-ci.com/build/4770244019879936).
Daniil Zakhlystov ________________________________________ From: Shlok Kyal <shlok.kyal....@gmail.com> Sent: Thursday, November 2, 2023 1:25 PM To: Zakhlystov, Daniil (Nebius) Cc: amboro...@acm.org; pgsql-hackers@lists.postgresql.org; Mokrushin, Mikhail (Nebius) Subject: Re: Force the old transactions logs cleanup even if checkpoint is skipped CAUTION: This email originated from outside mail organization. Do not click links or open attachments unless you recognize the sender. Hi, I went through the Cfbot and saw that some test are failing for it (link: https://cirrus-ci.com/task/4631357628874752): test: postgresql:recovery / recovery/019_replslot_limit # test failed ----------------------------------- stderr ----------------------------------- # poll_query_until timed out executing this query: # SELECT '0/15000D8' <= replay_lsn AND state = 'streaming' # FROM pg_catalog.pg_stat_replication # WHERE application_name IN ('standby_1', 'walreceiver') # expecting this output: # t # last actual query output: # # with stderr: # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 29 just after 7. I tried to test it locally and this test is timing out in my local machine as well. Thanks Shlok Kumar Kyal
0001-Cleanup-old-files-if-checkpoint-is-skipped.patch
Description: 0001-Cleanup-old-files-if-checkpoint-is-skipped.patch
