On Tue, Nov 7, 2023 at 10:01 AM Zhijie Hou (Fujitsu) <houzj.f...@fujitsu.com> wrote: > > On Tuesday, November 7, 2023 12:14 PM Kuroda, Hayato/黒田 隼人 > <kuroda.hay...@fujitsu.com> wrote: > > > > Dear hackers, > > > > PSA the patch to solve the issue [1]. > > > > Kindly Peter E. and Andrew raised an issue that delete_old_cluster.sh is > > generated in the source directory, even when the VPATH/meson build. > > This can avoid by changing the directory explicitly. > > > > [1]: > > https://www.postgresql.org/message-id/flat/7b8a9460-5668-b372-04e6-7b > > 52e9308493%40dunslane.net#554090099bbbd12c94bf570665a6badf > > Thanks for the patch, I have confirmed that the files won't be generated > in source directory after applying the patch. > > After running: "meson test -C build/ --suite pg_upgrade", > The files are in the test directory: > ./build/testrun/pg_upgrade/003_logical_slots/data/delete_old_cluster.sh >
Thanks for the patch and verification. Pushed the fix. -- With Regards, Amit Kapila.
