Dear Bharath, Amit, Peter, Thank you for discussing! A patch can be available in [1].
> > > > +1 for > s/003_upgrade_logical_replication_slots.pl/003_upgrade_logical_slots.pl > > > > and s/invalid_logical_replication_slots.txt/invalid_logical_slots.txt. > > > > +1. The proposed file name sounds reasonable. > > > > Agreed. So, how about 003_upgrade_logical_slots.pl or simply > > 003_upgrade_slots.pl? > > > > Why not simply oldpub/sub/newpub or old_pub/sub/new_pub? > > +1 for invalid_logical_slots.txt, 003_upgrade_logical_slots.pl and > oldpub/sub/newpub. With these changes, the path name is brought down > to ~220 chars. These names look good to me iff other things in the > path name aren't dynamic crossing MAX_PATH limit (260 chars). > > C:/tools/nmsys64/home/pgrunner/bf/root/HEAD/pgsql.build/testrun/pg_upgra > de/003_upgrade_logical_slots/data/t_003_upgrade_logical_slots_newpub_data/ > pgdata/pg_upgrade_output.d/20231026T112558.309/invalid_logical_slots.txt Replaced to invalid_logical_slots.txt, 003_logical_slots.pl, and oldpub/sub/newpub. Regarding the test finename, some client app (e.g., pg_ctl) does not have a prefix, and some others (e.g., pg_dump) have. Either way seems acceptable. Hence I chose to remove the header. ``` $ ls pg_ctl/t/ 001_start_stop.pl 002_status.pl 003_promote.pl 004_logrotate.pl $ ls pg_dump/t/ 001_basic.pl 002_pg_dump.pl 003_pg_dump_with_server.pl 004_pg_dump_parallel.pl 010_dump_connstr.pl ``` [1]: https://www.postgresql.org/message-id/TYCPR01MB5870A6A8FBB23554EDE8F5F3F5DCA%40TYCPR01MB5870.jpnprd01.prod.outlook.com Best Regards, Hayato Kuroda FUJITSU LIMITED
