On 2023-10-19 Th 02:06, Jeevan Chalke wrote:
Thanks, Peter for the comments.
On Fri, Oct 6, 2023 at 5:13 PM Peter Eisentraut <pe...@eisentraut.org>
wrote:
On 29.08.23 09:05, Jeevan Chalke wrote:
> v1-0001-Implement-jsonpath-.bigint-.integer-and-.number-m.patch
>
> This commit implements jsonpath .bigint(), .integer(), and .number()
> methods. The JSON string or a numeric value is converted to the
> bigint, int4, and numeric type representation.
A comment that applies to all of these: These add various keywords,
switch cases, documentation entries in some order. Are we happy with
that? Should we try to reorder all of that for better
maintainability
or readability?
Yeah, that's the better suggestion. While implementing these methods,
I was confused about where to put them exactly and tried keeping them
in some logical place.
I think once these methods get in, we can have a follow-up patch
reorganizing all of these.
I think it would be better to organize things how we want them before
adding in more stuff.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enterprisedb.com
