On Mon, Oct 16, 2023 at 08:45:00PM -0400, Tom Lane wrote: > 2. We could raise awareness of this issue by adding indent verification > to CI testing. I hesitate to suggest that, though, for a couple of > reasons: > 2a. It seems fairly expensive, though I might be misjudging. > 2b. It's often pretty handy to submit patches that aren't fully > indent-clean; I have such a patch in flight right now at [1]. > > 2b could be ameliorated by making the indent check be a separate > test process that doesn't obscure the results of other testing.
I see an extra reason with not doing that: this increases the difficulty when it comes to send and maintain patches to the lists and newcomers would need to learn more tooling. I don't think that we should make that more complicated for code-formatting reasons. -- Michael
signature.asc
Description: PGP signature