Dear Bharath, Thanks for giving comments and apologize for late reply. New version is available in [1].
> +1 for this approach. It looks neat. > > I think we also need to add TAP tests to generate decodable WAL > records (RUNNING_XACT, CHECKPOINT_ONLINE, XLOG_FPI_FOR_HINT, > XLOG_SWITCH, XLOG_PARAMETER_CHANGE, XLOG_HEAP2_PRUNE) during > pg_upgrade as described here > https://www.postgresql.org/message-id/TYAPR01MB58660273EACEFC5BF256 > B133F50DA%40TYAPR01MB5866.jpnprd01.prod.outlook.com. > Basically, these were the exceptional WAL records that may be > generated by pg_upgrade, so having tests for them is good. Hmm, I'm not sure it is really good. If we add such a test, we may have to add further tests in future if new WAL log types during upgrade is introduced. Currently we do not have if-statement for each WAL types, so it does not improve coverage, I thought. Another concern is that I'm not sure how do we simply and surely generate XLOG_HEAP2_PRUNE. Based on above, I did not add the test case for now. [1]: https://www.postgresql.org/message-id/TYAPR01MB5866068CB6591C8AE1F9690BF5CDA%40TYAPR01MB5866.jpnprd01.prod.outlook.com Best Regards, Hayato Kuroda FUJITSU LIMITED
