On Sat, 2023-01-14 at 12:34 -0800, Andres Freund wrote: > One benefit would be that it'd make it more realistic to use direct > IO for WAL > - for which I have seen significant performance benefits. But when we > afterwards have to re-read it from disk to replicate, it's less > clearly a win.
Does this patch still look like a good fit for your (or someone else's) plans for direct IO here? If so, would committing this soon make it easier to make progress on that, or should we wait until it's actually needed? If I recall, this patch does not provide a perforance benefit as-is (correct me if things have changed) and I don't know if a reduction in syscalls alone is enough to justify it. But if it paves the way for direct IO for WAL, that does seem worth it. Regards, Jeff Davis