Is this patch still being worked on?
On 07.03.23 01:51, Tom Lane wrote:
Andres Freund <and...@anarazel.de> writes:
On 2023-03-03 15:09:18 -0500, Tom Lane wrote:
It'd be good to have a header comment for ExecInitExprRec documenting
the arguments, particularly that resv/resnull are where to put the
subplan's eventual result.
Did you mean ExecInitSubPlanExpr()?
Right, copy-and-pasteo, sorry.
You could avoid having to assume ExprState's resvalue/resnull being
safe to use by instead using the target resv/resnull. This would
require putting those into the EEOP_PARAM_SET step so that
ExecEvalParamSet knows where to fetch from, so maybe it's not an
improvement, but perhaps worth considering.
I think that'd be a bit worse - we'd have more pointers that can't be handled
in a generic way in JIT.
OK.
regards, tom lane
