On Wed, 20 Sept 2023 at 22:08, Nathan Bossart <nathandboss...@gmail.com> wrote:
> I think we should also consider renaming things like SYNC_METHOD_FSYNC to > WAL_SYNC_METHOD_FSYNC, and sync_method_options to wal_sync_method_options. > I've already rename sync_method_options in previous patch. 34 @@ -171,7 +171,7 @@ static bool check_wal_consistency_checking_deferred = false; 35 /* 36 * GUC support 37 */ 38 -const struct config_enum_entry sync_method_options[] = { 39 +const struct config_enum_entry wal_sync_method_options[] = { As for SYNC_METHOD_FSYNC rename, PFA patch. Also make enum for WAL sync methods instead of defines. -- Best regards, Maxim Orlov.
v11-0001-Fix-conflicting-types-for-sync_method.patch
Description: Binary data