On Wed, Sep 20, 2023 at 12:12 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Wed, Sep 20, 2023 at 11:51 AM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > On Wed, Sep 20, 2023 at 11:00 AM Hayato Kuroda (Fujitsu) > > <kuroda.hay...@fujitsu.com> wrote: > > > > > > Dear Amit, > > > > > > Thank you for reviewing! PSA new version. In this version I ran pgindent > > > again. > > > > > > > + /* > > + * There is a possibility that following records may be generated > > + * during the upgrade. > > + */ > > + if (!CHECK_WAL_RECORD(rmid, info, RM_XLOG_ID, XLOG_CHECKPOINT_SHUTDOWN) && > > + !CHECK_WAL_RECORD(rmid, info, RM_XLOG_ID, XLOG_CHECKPOINT_ONLINE) && > > + !CHECK_WAL_RECORD(rmid, info, RM_XLOG_ID, XLOG_SWITCH) && > > + !CHECK_WAL_RECORD(rmid, info, RM_XLOG_ID, XLOG_FPI_FOR_HINT) && > > + !CHECK_WAL_RECORD(rmid, info, RM_XLOG_ID, XLOG_PARAMETER_CHANGE) && > > + !CHECK_WAL_RECORD(rmid, info, RM_STANDBY_ID, XLOG_RUNNING_XACTS) && > > + !CHECK_WAL_RECORD(rmid, info, RM_HEAP2_ID, XLOG_HEAP2_PRUNE)) > > + is_valid = false; > > + > > + CHECK_FOR_INTERRUPTS(); > > > > Just wondering why XLOG_HEAP2_VACUUM or other vacuum-related commands > > can not occur during the upgrade? > > > > Because autovacuum is disabled during upgrade. See comment: "Use -b to > disable autovacuum" in start_postmaster().
Okay got it, thanks. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
