On 19/09/2023 01:57, Andres Freund wrote:
On 2023-09-18 13:49:24 +0300, Heikki Linnakangas wrote:
d) Copy fewer rows to the table in the test. If we copy only 6 rows, for
example, the table will have only two pages, regardless of shared_buffers.
I'm leaning towards d). The whole test is a little fragile, it will also
fail with a non-default block size, for example. But c) seems like a simple
fix and wouldn't look too out of place in the test.
Hm, what do you mean with the last sentence? Oh, is the test you're
referencing the relation-extension logic?
Sorry, I said "c) seems like a simple fix ...", but I meant "d) seems
like a simple fix ..."
I meant the attached.
--
Heikki Linnakangas
Neon (https://neon.tech)
diff --git a/contrib/pg_visibility/expected/pg_visibility.out b/contrib/pg_visibility/expected/pg_visibility.out
index 9de54db2a2..09fa5933a3 100644
--- a/contrib/pg_visibility/expected/pg_visibility.out
+++ b/contrib/pg_visibility/expected/pg_visibility.out
@@ -217,8 +217,7 @@ select * from pg_visibility_map('copyfreeze');
-------+-------------+------------
0 | t | t
1 | t | t
- 2 | t | t
-(3 rows)
+(2 rows)
select * from pg_check_frozen('copyfreeze');
t_ctid
diff --git a/contrib/pg_visibility/sql/pg_visibility.sql b/contrib/pg_visibility/sql/pg_visibility.sql
index ff3538f996..5af06ec5b7 100644
--- a/contrib/pg_visibility/sql/pg_visibility.sql
+++ b/contrib/pg_visibility/sql/pg_visibility.sql
@@ -108,12 +108,6 @@ copy copyfreeze from stdin freeze;
4 '4'
5 '5'
6 '6'
-7 '7'
-8 '8'
-9 '9'
-10 '10'
-11 '11'
-12 '12'
\.
commit;
select * from pg_visibility_map('copyfreeze');
