> On 13 Sep 2023, at 01:49, Andres Freund <and...@anarazel.de> wrote: > On 2023-08-30 10:57:10 +0200, Daniel Gustafsson wrote: >>> On 28 Aug 2023, at 14:32, Daniel Gustafsson <dan...@yesql.se> wrote: >> >>> Attached is a patch with a quick PoC for using PQPing instead of using psql >>> for >>> connection checks in pg_regress. >> >> The attached v2 fixes a silly mistake which led to a compiler warning. > > Still seems like a good idea to me. To see what impact it has, I measured the > time running the pg_regress tests that take less than 6s on my machine - I > excluded the slower ones (like the main regression tests) because they'd hide > any overall difference.
> My patch increased user/sys time a bit (likely due to a higher number of > futile psql forks), but Daniel's doesn't. And it does show a nice overall wall > clock time saving. While it does add a lib dependency I think it's worth doing, so I propose we go ahead with this for master. -- Daniel Gustafsson