> On 13 Sep 2023, at 08:18, Michael Paquier <mich...@paquier.xyz> wrote:
> f = AllocateFile(path, PG_BINARY_R);
> if (!f)
> ereport(ERROR,
> - (errcode(ERRCODE_INVALID_PARAMETER_VALUE),
> - errmsg("invalid snapshot identifier: \"%s\"", idstr)));
> + (errcode_for_file_access(),
> + errmsg("could not open file \"%s\" for reading: %m",
> + path)));
>
> Agreed that this just looks like a copy-pasto. The path provides
> enough context about what's being read, so using this generic error
> message is fine. Will apply if there are no objections.
+1. This errmsg is already present so it eases the translation burden as well.
--
Daniel Gustafsson
