> > I guess the *valuable* sometimes means the effort we pay is greater > than the benefit we get, As for this patch, the benefit is not huge (it > is possible the compiler already does that). and the most effort we pay > should be committer's attention, who needs to grab the patch, write the > correct commit and credit to the author and push it. I'm not sure if > Aleksander is worrying that this kind of patch will grab too much of > the committer's attention and I do see there are lots of patches like > this. >
I forget to mention that the past contribution of the author should be a factor as well. Like Richard has provided lots of performance improvement, bug fix, code reviews, so I believe more attention from committers should be a reasonable request. -- Best Regards Andy Fan
