On Thu, Aug 31, 2023 at 6:12 PM Ashutosh Bapat <ashutosh.bapat....@gmail.com> wrote: > > On Thu, Aug 31, 2023 at 2:52 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > All but one. Normally, the idea of marking dirty is to indicate that > > we will actually write/flush the contents at a later point (except > > when required for correctness) as even indicated in the comments atop > > ReplicatioinSlotMarkDirty(). However, I see your point that we use > > that protocol at all the current places including CreateSlotOnDisk(). > > So, we can probably do it here as well. > > yes >
I think we should also ensure that slots are not invalidated (slot.data.invalidated != RS_INVAL_NONE) before marking them dirty because we don't allow decoding from such slots, so we shouldn't include those. -- With Regards, Amit Kapila.
