Hi, On 2023-08-24 08:18:14 +0200, Peter Eisentraut wrote: > On 23.08.23 14:52, David Rowley wrote: > > Generally when there are files left over the meson build script will > > detect this and ask you to run make maintainer-clean. That's useful > > on Linux, but on Windows you're just left to manually remove the > > conflicting files which are listed. Unfortunately, pg_config_paths.h > > wasn't listed, which I think was missed because it's not generated > > during configure, but during the actual make build. (see > > src/port/Makefile) > > How is this different from any other built file being left in the tree?
Files included into other files (i.e. mostly .h, but also a few .c) are particularly problematic, because they will be used from the source tree, if the #include doesn't have directory component - the current directory will always be searched first. In this case initdb on David's machine failed, because the paths from the wrong pg_config_paths.h was used. > Surely meson should not be required to detect that? I think we should try to detect included files, due to the nasty and hard to debug issues that creates. I've spent quite a bit of time helping people to debug such issues. Greetings, Andres Freund
