Dear Amit, Thanks for the comment! Next version will be available in upcoming post.
> > > + /* logical replication slots can be migrated since PG17. */ > > > + if (GET_MAJOR_VERSION(new_cluster->major_version) <= 1600) > > > + return; > > > > > > IMO the code matches the comment better if you say < 1700 instead of <= > 1600. > > > > Changed. > > > > I think it is better to be consistent with the existing code. There > are a few other checks in pg_upgrade.c that uses <=, so it is better > to use it in the same way here. OK, reverted. > Another minor comment: > Note that > + if the new cluser uses different port number from old one, > + <link linkend="sql-altersubscription"><command>ALTER > SUBSCRIPTION ... CONNECTION</command></link> > + command must be also executed on subscriber. > > I think this is true in general as well and not specific to > pg_upgrade. So, we can avoid adding anything about connection change > here. Removed. Best Regards, Hayato Kuroda FUJITSU LIMITED
