Hi, On Mon, Aug 14, 2023 at 5:12 PM Masahiro Ikeda <ikeda...@oss.nttdata.com> wrote: > > Hi, > > On 2023-08-13 04:12, Andres Freund wrote: > > On 2023-08-10 17:48:10 +0900, Masahiko Sawada wrote: > >> Good catch! I've confirmed that the issue has been fixed by your > >> patch. > > > > Indeed. > > Thanks for your responses! > > >> However, I'm not sure the added regression tests are stable since > >> autovacuum workers may scan the pg_database and increment the > >> statistics after resetting the stats. > > > > What about updating the table and checking the update count is reset? > > That'd > > not be reset by autovacuum. > > Yes. I confirmed that the stats are incremented by autovacuum as you > said. > > I updated the patch to v3. > * remove the code to bump the CATALOG_VERSION_NO because I misunderstood > * change the test logic to check the update count instead of scan count
Thank you for updating the patch! > > I changed the table to check the stats from pg_database to > pg_shdescription > because the stats can update via the SQL interface COMMENT command. It seems to work well. +COMMENT ON DATABASE :current_database IS 'This is a test comment'; -- insert or update in 'pg_shdescription' I think the current_database should be quoted (see other examples where using current_database(), e.g. collate.linux.utf8.sql). Also it would be better to reset the comment after the test. Regards, -- Masahiko Sawada Amazon Web Services: https://aws.amazon.com
