Hi, I've fixed the Autotools build, please check patch below (v2).
On Thu, Jul 27, 2023 at 6:39 PM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi, > > > Also FYI, there are build warnings because functions > > const char * get_span_name(const Span * span, const char *qbuffer) > > and > > const char * get_operation_name(const Span * span, const char *qbuffer) > > do not have default inside switch and no return outside of switch. > > You are right, there are a few warnings: > > ``` > [1566/1887] Compiling C object contrib/pg_tracing/pg_tracing.so.p/span.c.o > ../contrib/pg_tracing/span.c: In function ‘get_span_name’: > ../contrib/pg_tracing/span.c:210:1: warning: control reaches end of > non-void function [-Wreturn-type] > 210 | } > | ^ > ../contrib/pg_tracing/span.c: In function ‘get_operation_name’: > ../contrib/pg_tracing/span.c:249:1: warning: control reaches end of > non-void function [-Wreturn-type] > 249 | } > | ^ > ``` > > Here is the patch v2 with a quick fix. > > > but got errors calling make check and cannot install the extension > > Agree, something goes wrong when using Autotools (but not Meson) on > both Linux and MacOS. I didn't investigate the issue though. > > -- > Best regards, > Aleksander Alekseev > -- Regards, -- Nikita Malakhov Postgres Professional The Russian Postgres Company https://postgrespro.ru/
pg-tracing-v2.patch
Description: Binary data
