On Wed, Jul 19, 2023 at 06:49:57PM +0530, Amit Kapila wrote: > On Mon, Jul 17, 2023 at 10:26 PM Andres Freund <and...@anarazel.de> wrote: >> FWIW, the former is bottlenecked by the number of WAL insertion locks, the >> second is bottlenecked by copying WAL into buffers due to needing to flush >> them. > > This gives a better idea of what's going on. +1 for separating these waits.
+ * As this is not used to wait for lwlocks themselves, the caller has to + * provide a wait event to be reported. */ bool -LWLockWaitForVar(LWLock *lock, uint64 *valptr, uint64 oldval, uint64 *newval) +LWLockWaitForVar(LWLock *lock, uint64 *valptr, uint64 oldval, uint64 *newval, + uint32 wait_event_info) Makes sense to me to do this split, nice! And this gives more flexibility for out-of-core callers, while on it. -- Michael
signature.asc
Description: PGP signature
