On 7/14/23 16:02, Ashutosh Bapat wrote: > ... >>>>> >>>> >>>> Hmmmm, that might work. I feel a bit uneasy about having to keep all >>>> relfilenodes, not just sequences ... >>> >>> From relfilenode it should be easy to get to rel and then see if it's >>> a sequence. Only add relfilenodes for the sequence. >>> >> >> Will try. >> > > Actually, adding all relfilenodes to hash may not be that bad. There > shouldn't be many of those. So the extra step to lookup reltype may > not be necessary. What's your reason for uneasiness? But yeah, there's > a way to avoid that as well. > > Should I wait for this before the second round of review? >
I don't think you have to wait - just ignore the part that changes the WAL record, which is a pretty tiny bit of the patch. regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
