On Fri, Jul 7, 2023 at 6:01 PM Thomas Munro <thomas.mu...@gmail.com> wrote: > > On Fri, Jul 7, 2023 at 4:57 AM Jacob Champion <jchamp...@timescale.com> wrote: > > On Wed, Jul 5, 2023 at 3:07 PM Thomas Munro <thomas.mu...@gmail.com> wrote: > > > BTW I will happily do the epoll->kqueue port work if necessary. > > > > And I will happily take you up on that; thanks! > > Some initial hacking, about 2 coffees' worth: > https://github.com/macdice/postgres/commits/oauth-kqueue > > This compiles on FreeBSD and macOS, but I didn't have time to figure > out all your Python testing magic so I don't know if it works yet and > it's still red on CI...
This is awesome, thank you! I need to look into the CI more, but it looks like the client tests are passing, which is a good sign. (I don't understand why the server-side tests are failing on FreeBSD, but they shouldn't be using the libpq code at all, so I think your kqueue implementation is in the clear. Cirrus doesn't have the logs from the server-side test failures anywhere -- probably a bug in my Meson patch.) > one thing I wondered about is the *altsock = > timerfd part which I couldn't do. I did that because I'm not entirely sure that libcurl is guaranteed to have cleared out all its sockets from the mux, and I didn't want to invite spurious wakeups. I should probably verify whether or not that's possible. If so, we could just make that code resilient to early wakeup, so that it matters less, or set up a second kqueue that only holds the timer if that turns out to be unacceptable? > The situation on macOS is a little odd: the man page says EVFILT_TIMER > is not implemented. But clearly it is, we can read the source code as > I had to do to find out which unit of time it defaults to[1] (huh, > Apple's github repo for Darwin appears to have been archived recently > -- no more source code updates? that'd be a shame!), and it works > exactly as expected in simple programs. So I would just assume it > works until we see evidence otherwise. (We already use a couple of > other things on macOS more or less by accident because configure finds > them, where they are undocumented or undeclared.) Huh. Something to keep an eye on... might be a problem with older versions? Thanks! --Jacob
