Hi, Thanks for your comments.
Tom Lane <t...@sss.pgh.pa.us>, 28 Haz 2023 Çar, 13:59 tarihinde şunu yazdı: > > David Rowley <dgrowle...@gmail.com> writes: > > Perhaps it's ok to leave the context creation functions with Size > > typed parameters and then just Assert the passed-in sizes are not > > larger than 1GB within the context creation function. > > Yes, I'm strongly opposed to not using Size/size_t in the mmgr APIs. > If we go that road, we're going to have a problem when someone > inevitably wants to pass a larger-than-GB value for some context > type. I reverted changes in the context creation functions and only changed the types in structs. I believe there are already lines to assert whether the sizes are less than 1GB, so we should be safe there. Andres Freund <and...@anarazel.de>, 29 Haz 2023 Per, 02:34 tarihinde şunu yazdı: > There are a few other fields that we can get rid of. > > - Afaics AllocSet->keeper is unnecessary these days, as it is always allocated > together with the context itself. Saves 8 bytes. This seemed like a safe change and removed the keeper field in AllocSet and Generation contexts. It saves an additional 8 bytes. Best, -- Melih Mutlu Microsoft
v2-0001-Change-memory-context-fields-to-uint32.patch
Description: Binary data
