On Wed, Jun 28, 2023 at 3:36 PM Michael Paquier <mich...@paquier.xyz> wrote:
> On Wed, Jun 28, 2023 at 03:09:55PM +0800, Richard Guo wrote: > > +1. To nitpick, how about we remove the blank line just before removing > > the key for top level entry? > > > > - /* Also remove entries for top level statements */ > > + /* Also remove entries if exist for top level statements */ > > key.toplevel = true; > > - > > - /* Remove the key if exists */ > > entry = (pgssEntry *) hash_search(pgss_hash, &key, HASH_REMOVE, NULL); > > Why not if it improves the overall situation. Could you send a patch > with everything you have in mind? Here is the patch. I don't have too much in mind, so the patch just removes the blank line and revises the comment a bit. Thanks Richard
v1-0001-trivial-revise-for-entry_reset.patch
Description: Binary data
