On Fri, 23 Jun 2023 at 05:59, Michael Paquier <mich...@paquier.xyz> wrote:
> [...]
> res = PQgetResult(conn);
> if (res == NULL)
> - pg_fatal("expected NULL result");
> + pg_fatal("expected non-NULL result");
>
> This should check for the NULL-ness of the result returned for
> PQclosePrepared() rather than changing the behavior of the follow-up
> calls?To be clear, it didn't actually change the behaviour. I only changed the error message, since it said the exact opposite of what it was expecting. I split this minor fix into its own commit now to clarify that. I think it would even make sense to commit this small patch to the PG16 branch, since it's a bugfix in the tests (and possibly even back-patch to others if that's not a lot of work). I changed the error message to be in line with one from earlier in the test. I addressed all of your other comments.
v6-0002-Support-sending-Close-messages-from-libpq.patch
Description: Binary data
v6-0001-Correct-error-message-in-test_prepared.patch
Description: Binary data
