Tom Lane <t...@sss.pgh.pa.us> writes: > Gurjeet Singh <gurj...@singh.im> writes: >> On Thu, Jun 8, 2023 at 7:35 AM Tom Lane <t...@sss.pgh.pa.us> wrote: >>> This bug is very ancient, dating to commit 79d78bb26 which >>> added encode.c. (The other instances were presumably copied >>> from there.) Still, it doesn't quite seem worth back-patching. > >> Is it worth investing time in trying to unify these 3 occurrences of >> base64 length (and possibly other relevant) code to one place? If yes, >> I can volunteer for it. > > I wondered about that too. It seems really silly that we made > a copy in src/common and did not replace the others with calls > to that.
Also, while we're at it, how about some unit tests that both encode and calculate the encoded length of strings of various lengths and check that they match? - ilmari
