Hi Michael,
04.06.2023 01:42, Michael Paquier wrote:
On Sat, Jun 03, 2023 at 03:00:01PM +0300, Alexander Lakhin wrote:
Clang' scan-build detects 58 errors "Dead assignment", including that one.
Maybe it would be more sensible to eliminate all errors of this class?
Depends on if this makes any code changed a bit easier to understand I
guess, so that would be a case-by-case analysis. Saying that, the
proposed patch seems right while it makes slightly easier to
understand the footer print part.
It also aligns the code with print_unaligned_vertical(), but I can't see why
need_recordsep = true;
is a no-op here (scan-build dislikes only need_recordsep = false;).
I suspect that removing that line will change the behaviour in cases when
need_recordsep = false after the loop "print cells" and the loop
"for (footers)" is executed.
Best regards,
Alexander
