On Thu, May 25, 2023 at 7:09 PM Michael Paquier <mich...@paquier.xyz> wrote:
> Please find attached an updated patch only for the removal of 1.0.1.
> Thanks for the review.
Nice! Sorry about the new complications with LibreSSL. :(
> - # Functions introduced in OpenSSL 1.0.2. LibreSSL does not have
> + # Function introduced in OpenSSL 1.0.2. LibreSSL does not have
> # SSL_CTX_set_cert_cb().
> - AC_CHECK_FUNCS([X509_get_signature_nid SSL_CTX_set_cert_cb])
> + AC_CHECK_FUNCS([SSL_CTX_set_cert_cb])
Can X509_get_signature_nid be moved to the required section up above?
As it is now, anyone configuring with -Dssl=auto can still pick up a
1.0.1 build, which Meson accepts, and then the build fails downstream.
If we require the function instead, Meson will ignore 1.0.1 (or, for
-Dssl=openssl, complain before we compile).
t/001_ssltests.pl has a reference to 1.0.1 that can probably be
entirely deleted:
# ... (Nor for OpenSSL
# 1.0.1, but that's old enough that accommodating it isn't worth the cost.)
Thanks,
--Jacob
