On Tue, May 23, 2023 at 06:37:59PM -0700, Andres Freund wrote: > This feels more like a matter of taste to me than anything.
Yup, it is. > At least some of > the files touched in the patch use optarg, opterr etc. - which are declared in > pg_getopt.h. Making it reasonable to directly include pg_getopt.h. getopt_long.h is included in 21 places of src/bin/, with all of them touching optarg, while only four of them include pg_getopt.h. So removing them as suggested makes sense. I agree with the tasting matter as well, still there is also a consistency matter. -- Michael
signature.asc
Description: PGP signature
