On Tue, May 23, 2023 at 4:22 AM Daniele Varrazzo <daniele.varra...@gmail.com> wrote: > On Sat, 20 May 2023 at 00:01, Jacob Champion <jchamp...@timescale.com> wrote: > > - Some clients in the wild (psycopg2/psycopg) suppress all notifications > > during PQconnectPoll(). > > If there is anything we can improve in psycopg please reach out.
Will do, thank you! But in this case, I think there's nothing to improve in psycopg -- in fact, it highlighted the problem with my initial design, and now I think the notice processor will never be an appropriate avenue for communication of the user code. The biggest issue is that there's a chicken-and-egg situation: if you're using the synchronous PQconnect* API, you can't override the notice hooks while the handshake is in progress, because you don't have a connection handle yet. The second problem is that there are a bunch of parameters coming back from the server (user code, verification URI, expiration time) that the application may choose to display or use, and communicating those pieces in a (probably already translated) flat text string is a pretty hostile API. So I think we'll probably need to provide a global handler API, similar to the passphrase hook we currently provide, that can receive these pieces separately and assemble them however the application desires. The hard part will be to avoid painting ourselves into a corner, because this particular information is specific to the device authorization flow, and if we ever want to add other flows into libpq, we'll probably not want to add even more hooks. Thanks, --Jacob
